abstractdog commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1925150810
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -330,6 +330,13 @@ public void analyze(ASTNode ast, Context ctx) throws
SemanticException {
initCtx(ctx);
init(true);
analyzeInternal(ast);
+ setQueryPropertiesAfterAnalyze();
+ }
+
+ private void setQueryPropertiesAfterAnalyze() {
+ if (queryProperties != null && getQB() != null){
+ queryProperties.extractInfoFromQueryBlock(getQB());
Review Comment:
ready to change naming
the issue with ordering is that we have tons of semantic analyzer
subclasses, and they tend to inherit analyzerInternal
as I want to be independent of them, I must run this
afterwards...setQueryPropertiesAfterAnalyze is indeed weird, what about
changing it to:
```
private void postAnalyze()
```
adding javadoc also
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
