deniskuzZ commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1930715520
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java:
##########
@@ -688,6 +689,13 @@ DAGClient submit(DAG dag, Ref<TezSessionState>
sessionStateRef) throws Exception
return new SyncDagClient(dagClient);
}
+ private DAGClient submitInternal(DAG dag, TezSessionState sessionState)
throws TezException, IOException {
+ TezClient tezClient = sessionState.getSession();
+ DAGClient dagClient = tezClient.submitDAG(dag);
+ runtimeContext.init(tezClient);
Review Comment:
can we refactor
````
private DAGClient submitInternal(DAG dag, TezSessionState sessionState)
throws TezException, IOException {
runtimeContext.init(sessionState);
return sessionState.getSession().submitDAG(dag);
}
TezRuntimeContext.class
public void init(TezSessionState sessionState) {
this.amAddress = sessionState.getAppMasterUri();
}
TezSessionState.class
String getAppMasterUri() {
return Optional.of(getSession()).map(
session -> session.getAmHost() + ":" + session.getAmPort())
.get();
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
