deniskuzZ commented on code in PR #5613:
URL: https://github.com/apache/hive/pull/5613#discussion_r1930743110
##########
ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java:
##########
@@ -2047,8 +2070,8 @@ public void startAnalysis() {
/**
* Called when we end analysis of a query.
*/
- public void endAnalysis() {
- // Nothing to do
+ public void endAnalysis(ASTNode tree) {
+ setQueryType(tree); // at this point we know the query type for sure
Review Comment:
can't we set the queryType in `analyzeInternal(ast)` so we don't need to
pass `ast` in `endAnalysis`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
