difin commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932738256
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergCompactionUtil.java:
##########
@@ -55,6 +60,12 @@ public static boolean shouldIncludeForCompaction(Table
table, String partitionPa
table.specs().get(file.specId()).partitionToPath(file.partition()).equals(partitionPath);
}
+ public static boolean shouldIncludeForCompaction(Table table, String
partitionPath, ContentFile<?> file,
Review Comment:
I missed it. Updated to include will in compaction if it meets file size
threshold or if any deletes exist.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
