deniskuzZ commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1932712424
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorContext.java:
##########
@@ -37,6 +37,7 @@ public class CompactorContext {
private final ValidWriteIdList validWriteIdList;
private final CompactionInfo compactionInfo;
private final AcidDirectory dir;
+ public static final String COMPACTION_FILE_SIZE_THRESHOLD =
"compaction.file.size.threshold";
Review Comment:
we should also support MAX_FILE_GROUP_SIZE_BYTES where we construct list of
files to be included for compaction
optionally DELETE_FILE_THRESHOLD. don't know if we can easily check num of
delete files that reference data file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
