kasakrisz commented on code in PR #5647:
URL: https://github.com/apache/hive/pull/5647#discussion_r1965193447
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -7303,6 +7304,12 @@ public Map<String, String> subtree(String string) {
return ret;
}
+ public static boolean shouldComputeLineage(HiveConf conf) {
+ Collection<String> lineage_filter =
+
conf.getTrimmedStringCollection(HiveConf.ConfVars.HIVE_LINEAGE_STATEMENT_FILTER.varname);
+ return !(lineage_filter.isEmpty() || lineage_filter.contains("NONE"));
Review Comment:
I think HIVE_LINEAGE_INFO also has to be checked like
```
return !(lineage_filter.isEmpty() || lineage_filter.contains("NONE")) ||
conf.getBoolVar(HiveConf.ConfVars.HIVE_LINEAGE_INFO);
```
Or it should be removed completely since it is deprecated.
Maybe we should keep it in the next Hive release but remove it in a
follow-up patch for the 2nd release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
