kasakrisz commented on PR #5647: URL: https://github.com/apache/hive/pull/5647#issuecomment-2677700594
> > > @Aggarwal-Raghav > > > > The lineage information computation will be by-default enabled for ALL query. > > > > > > > > > I think currently `org.apache.hadoop.hive.ql.hooks.PostExecutePrinter` is always added to `hive.exec.post.hooks` in `hive-site.xml` so it has the same impact. Could you please double check? > > > > > > No, i don't think it is always getting added in _hive-site.xml_. I checked in _hive-default.xml.template_ (which is created for new hive dist in conf dir) and also checked in local cluster, if _hive.exec.post.hooks_ key is not set in hive-site.xml then: > > ``` > > 0: jdbc:hive2://localhost:10000 (default)> set hive.exec.post.hooks; > > +------------------------------------+ > > | set | > > +------------------------------------+ > > | hive.exec.post.hooks is undefined | > > +------------------------------------+ > > ``` > > Yes. As I remember, PostExecutePrinter is added for qtests. That is the reason why you can see those "lineageinfo:" entries in the q.out files. They consume config files from the data/conf/... path. But they are not enabled by default. I see. Thank you guys for looking after this. I think to keep the current behavior we should * set the default value of `HIVE_LINEAGE_STATEMENT_FILTER` to `NONE` in the code - so in releases the lineage generation is kept turned off. * set `HIVE_LINEAGE_STATEMENT_FILTER` to `ALL` in `hive-site.xml`-s of qtests where `org.apache.hadoop.hive.ql.hooks.PostExecutePrinter` is added. I think we should kept linage generation enabled in tests because we need the test coverage of this functionality. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
