deniskuzZ commented on code in PR #5540: URL: https://github.com/apache/hive/pull/5540#discussion_r1973267847
########## iceberg/iceberg-handler/src/test/queries/positive/iceberg_major_compaction_unpartitioned_w_filter.q: ########## @@ -29,7 +29,7 @@ create table ice_orc ( last_name string ) stored by iceberg stored as orc -tblproperties ('format-version'='2'); Review Comment: I am starting to think if we should have extracted the defaults into Hive conf, WDYT? if global defaults are bad, users would need to override at the table level for all DBs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org