difin commented on code in PR #5540:
URL: https://github.com/apache/hive/pull/5540#discussion_r1955017036


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorContext.java:
##########
@@ -37,6 +37,7 @@ public class CompactorContext {
   private final ValidWriteIdList validWriteIdList;
   private final CompactionInfo compactionInfo;
   private final AcidDirectory dir;
+  public static final String COMPACTION_FILE_SIZE_THRESHOLD = 
"compaction.file.size.threshold"; 

Review Comment:
   Added support for the following table properties which are tied to Amoro 
configs:
   
   ```
     public static final String COMPACTOR_THRESHOLD_PREFIX = 
"compactor.threshold";
     public static final String COMPACTION_FILE_SIZE_THRESHOLD = 
COMPACTOR_THRESHOLD_PREFIX + ".file.size.threshold";
     public static final String COMPACTION_TARGET_SIZE = 
COMPACTOR_THRESHOLD_PREFIX + ".target.size";
     public static final String COMPACTION_MIN_FRAGMENT_RATIO = 
COMPACTOR_THRESHOLD_PREFIX + ".fragment.ratio"; 
     public static final String COMPACTION_MIN_TARGET_SIZE_RATIO = 
COMPACTOR_THRESHOLD_PREFIX + ".min.target.size.ratio"; 
     public static final String COMPACTION_MIN_INPUT_FILES = 
COMPACTOR_THRESHOLD_PREFIX + ".min.input.files"; 
     public static final String COMPACTION_DELETE_FILE_RATIO = 
COMPACTOR_THRESHOLD_PREFIX + ".delete.file.ratio"; 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to