ayushtkn commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1976505120
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -176,4 +187,9 @@ private void prepareConfForWrite() {
SessionStateUtil.addCommitInfo(SessionState.getSessionConf(),
tableDesc.getTableName(), jobId, 1,
Maps.fromProperties(tableDesc.getProperties()));
}
+
+ private void expireSnapshots() {
+ storageHandler.executeOperation(table, new
AlterTableExecuteSpec<>(EXPIRE_SNAPSHOT,
+ new AlterTableExecuteSpec.ExpireSnapshotsSpec(10)));
Review Comment:
Do you want to hardcode ``10`` here or just pass ``null`` & let the
TBLPROPERTIES handle it, this way it can be configurable also by ALTER command.
I don't think this would work the way you expect, there is some default time
thing as well
```
public static final String MAX_SNAPSHOT_AGE_MS =
"history.expire.max-snapshot-age-ms";
public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 432000000L;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
