tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1977092847
##########
standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStoreTimeout.java:
##########
@@ -181,7 +181,7 @@ public void testConnectionTimeout() throws Exception {
try(HiveMetaStoreClient c = new HiveMetaStoreClient(newConf)) {
Assert.fail("should throw connection timeout exception.");
} catch (MetaException e) {
- Assert.assertTrue("unexpected Exception",
e.getMessage().contains("connect timed out"));
+ Assert.assertTrue("unexpected Exception",
e.getMessage().toLowerCase().contains("connect timed out"));
Review Comment:
As part of [JEPS-353](https://openjdk.org/jeps/353), the default socket
implementation in java has been replaced to NioSocketImpl from the earlier
PlainSocketImpl which is being used internally in this testcase. This caused
the exception message to change from "connect timed out" to "Connect timed out".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
