tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r1976958608
##########
common/src/java/org/apache/hadoop/hive/common/CopyOnFirstWriteProperties.java:
##########
@@ -361,6 +361,7 @@ public void setInterned(Properties p) {
public CopyOnFirstWriteProperties() {
}
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification = "HIVE-23613:
intended_TO_DO")
Review Comment:
We had to upgrade spotbugs-maven-plugin from 4.0.0 to 4.5.0.0 for jdk-17
compatibility, this upgrade caused that the plugin detects bugs with respect to
its new/modified rules. one of the crucial new detection rule that was added
was:
- MS_EXPOSE_REP and EI_EXPOSE_REP are now reported for code returning a
reference to a mutable object indirectly (e.g. via a local variable)
[Spotbugs-maven-plugin release
notes](https://github.com/spotbugs/spotbugs/blob/master/CHANGELOG.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
