ayushtkn commented on code in PR #5672: URL: https://github.com/apache/hive/pull/5672#discussion_r1978770491
########## iceberg/iceberg-handler/src/test/queries/positive/alter_table_create_tag.q: ########## @@ -31,8 +31,8 @@ explain alter table iceTbl drop tag test_tag_2; alter table iceTbl drop tag test_tag_2; -- drop a tag with if exists -explain alter table iceTbl drop tag if exists test_tag_3; -alter table iceTbl drop tag if exists test_tag_3; +explain alter table iceTbl drop tag if exists test_tag_1; +alter table iceTbl drop tag if exists test_tag_1; Review Comment: this was correct only, it is testing if the tag doesn't exist dropping the tag with if exist should make the query fail. That is intentionally using a tag which doesn't exist to test the "if exists" functionality -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
