kokila-19 commented on code in PR #5672: URL: https://github.com/apache/hive/pull/5672#discussion_r1978824840
########## iceberg/iceberg-handler/src/test/queries/positive/alter_table_create_tag.q: ########## @@ -31,8 +31,8 @@ explain alter table iceTbl drop tag test_tag_2; alter table iceTbl drop tag test_tag_2; -- drop a tag with if exists -explain alter table iceTbl drop tag if exists test_tag_3; -alter table iceTbl drop tag if exists test_tag_3; +explain alter table iceTbl drop tag if exists test_tag_1; +alter table iceTbl drop tag if exists test_tag_1; Review Comment: We are doing that in the next query and the comment specifically mentions that its dropping a non-existing tag. Current queries: 1. drop an existing tag. 2. drop an existing tag with if exists (The tag used here does not exist) 3. drop a non-existing tag with if exists (The tag used here does not exist) So, 2 and 3 are redundant. The missing case is testing the drop of existing tag using 'if exists' keyword. So I changed to the tag that exists. ``` -- drop a tag explain alter table iceTbl drop tag test_tag_2; alter table iceTbl drop tag test_tag_2; -- drop a tag with if exists explain alter table iceTbl drop tag if exists test_tag_3; // test_tag_3 does not exist alter table iceTbl drop tag if exists test_tag_3; -- drop a non-exist tag with if exists alter table iceTbl drop tag if exists test_tag_4; // test_tag_4 does not exist. ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
