difin commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1993483344
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -612,40 +615,43 @@ private Table
getTable(org.apache.hadoop.hive.ql.metadata.Table hmsTable) {
@Override
public boolean canSetColStatistics(org.apache.hadoop.hive.ql.metadata.Table
hmsTable) {
- Table table = IcebergTableUtil.getTable(conf, hmsTable.getTTable());
- return table.currentSnapshot() != null &&
getStatsSource().equals(HiveMetaHook.ICEBERG);
+ return getStatsSource().equals(HiveMetaHook.ICEBERG);
}
@Override
public boolean setColStatistics(org.apache.hadoop.hive.ql.metadata.Table
hmsTable, List<ColumnStatistics> colStats) {
Table tbl = IcebergTableUtil.getTable(conf, hmsTable.getTTable());
- return writeColStats(colStats.get(0), tbl);
+ return writeColStats(colStats, tbl);
}
- private boolean writeColStats(ColumnStatistics tableColStats, Table tbl) {
+ private boolean writeColStats(List<ColumnStatistics> colStats, Table tbl) {
try {
if (!shouldRewriteColStats(tbl)) {
- checkAndMergeColStats(tableColStats, tbl);
+ checkAndMergeColStats(colStats, tbl);
}
// Currently, we are only serializing table level stats.
Review Comment:
this comment seems to be outdated with these changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
