difin commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1993528869
##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandlerTestUtils.java:
##########
@@ -126,6 +126,10 @@ static TestTables testTables(TestHiveShell shell,
TestTables.TestTableType testT
return testTableType.instance(shell.metastore().hiveConf(), temp,
catalogName);
}
+ static void init(TestHiveShell shell, TestTables testTables, TemporaryFolder
temp) {
+ init(shell, testTables, temp, "tez");
Review Comment:
Should an enum be used here instead of hardcoded "tez" value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
