abstractdog commented on code in PR #5649: URL: https://github.com/apache/hive/pull/5649#discussion_r1993563579
########## service/src/java/org/apache/hive/service/cli/CLIService.java: ########## @@ -133,6 +134,15 @@ private void applyAuthorizationConfigPolicy(HiveConf newHiveConf) throws HiveExc ss.setIsHiveServerQuery(true); SessionState.start(ss); ss.applyAuthorizationPolicy(); + + // Add shutdown hook to close the session. + ShutdownHookManager.addShutdownHook(() -> { Review Comment: does it make sense to introduce something like: ``` ss.closeOnExit() ``` which will be reusable on the SessionState object level -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org