deniskuzZ commented on code in PR #5649:
URL: https://github.com/apache/hive/pull/5649#discussion_r1993405052
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/compaction/IcebergQueryCompactor.java:
##########
@@ -108,19 +108,16 @@ public boolean run(CompactorContext context) throws
IOException, HiveException,
VirtualColumn.FILE_PATH.getName(), fileSizePredicate == null ? "" :
"and " + fileSizePredicate, orderBy);
}
- SessionState sessionState = setupQueryCompactionSession(conf, ci,
tblProperties);
String compactionTarget = "table " +
HiveUtils.unparseIdentifier(compactTableName) +
- (partSpec != null ? ", partition " +
HiveUtils.unparseIdentifier(partSpec) : "");
+ (partSpec != null ? ", partition " +
HiveUtils.unparseIdentifier(partSpec) : "");
- try {
+ try (SessionState sessionState = setupQueryCompactionSession(conf, ci,
tblProperties)) {
Review Comment:
that looks valid to me, however, I am a bit confused as to why we had to
reset compaction marker on a session object in finally??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
