zratkai commented on code in PR #5648:
URL: https://github.com/apache/hive/pull/5648#discussion_r1995262854
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -695,25 +700,64 @@ public List<ColumnStatisticsObj>
getColStatistics(org.apache.hadoop.hive.ql.meta
ColumnStatistics emptyStats = new ColumnStatistics();
if (snapshot != null) {
return IcebergTableUtil.getColStatsPath(table, snapshot.snapshotId())
- .map(statsPath -> readColStats(table, statsPath))
+ .map(statsPath -> readColStats(table, statsPath, null).get(0))
.orElse(emptyStats).getStatsObj();
}
return emptyStats.getStatsObj();
}
- private ColumnStatistics readColStats(Table table, Path statsPath) {
+ @Override
+ public AggrStats getAggrColStatsFor(org.apache.hadoop.hive.ql.metadata.Table
hmsTable, List<String> colNames,
Review Comment:
I think some word is missing from the method name.
For... ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
