deniskuzZ commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1987676359
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -176,4 +193,13 @@ private void prepareConfForWrite() {
SessionStateUtil.addCommitInfo(SessionState.getSessionConf(),
tableDesc.getTableName(), jobId, 1,
Maps.fromProperties(tableDesc.getProperties()));
}
+
+ private void expireSnapshots() {
Review Comment:
We have an `AcidHouseKeeperService`, I think we should create a similar
`IcebergHouseKeeperService` and schedule periodic snapshot expiry on Iceberg
tables.
You can define the expiry policy for the `query-history` table and
`IcebergHouseKeeperService` / `IcebergTableExpiryService` would take care of it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
