deniskuzZ commented on code in PR #5666:
URL: https://github.com/apache/hive/pull/5666#discussion_r1990166686
##########
ql/src/java/org/apache/hadoop/hive/ql/queryhistory/repository/IcebergRepository.java:
##########
@@ -176,4 +193,13 @@ private void prepareConfForWrite() {
SessionStateUtil.addCommitInfo(SessionState.getSessionConf(),
tableDesc.getTableName(), jobId, 1,
Maps.fromProperties(tableDesc.getProperties()));
}
+
+ private void expireSnapshots() {
Review Comment:
1. you don't need to go down to partition level;
2. you can get list of iceberg tables from HMS, there is an API for that;
3. yes, service should be optimized.
- check the last housekeeping event,
- check if there were any changes to the table since last attempt (check if
metadata file hasn't changed),
- support table name filtering;
4. adding it just for query history, doesn't bring much value and is not
generic;
5. downstream you can configure all policies in DLM so you don't need this
at all;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
