deniskuzZ commented on code in PR #5710:
URL: https://github.com/apache/hive/pull/5710#discussion_r2009065630
##########
standalone-metastore/metastore-rest-catalog/src/main/java/org/apache/iceberg/rest/HMSCatalogFactory.java:
##########
@@ -117,7 +118,8 @@ protected Catalog createCatalog() {
* @return the servlet
*/
protected HttpServlet createServlet(Catalog catalog) {
- ServletSecurity security = new ServletSecurity(configuration);
+ String auth = MetastoreConf.getVar(configuration,
ConfVars.ICEBERG_CATALOG_SERVLET_AUTH);
Review Comment:
do we even need `ICEBERG_CATALOG_SERVLET_AUTH`config, it's only set in tests?
````
public static boolean isAuthJwt(Configuration configuration) {
String auth = MetastoreConf.getVar(configuration,
MetastoreConf.ConfVars.PROPERTIES_SERVLET_AUTH);
return "jwt".equalsIgnoreCase(auth);
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
