deniskuzZ commented on code in PR #5710:
URL: https://github.com/apache/hive/pull/5710#discussion_r2009113202
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ServletSecurity.java:
##########
@@ -85,21 +85,12 @@ public class ServletSecurity {
private final Configuration conf;
private JWTValidator jwtValidator = null;
- public ServletSecurity(Configuration conf) {
- this(conf, isAuthJwt(conf));
- }
-
public ServletSecurity(Configuration conf, boolean jwt) {
this.conf = conf;
this.isSecurityEnabled = UserGroupInformation.isSecurityEnabled();
this.jwtAuthEnabled = jwt;
}
- public static boolean isAuthJwt(Configuration configuration) {
Review Comment:
can we keep a method just add an extra param?
````
public static boolean isAuthJwt(Configuration conf, MetastoreConf.ConfVars
var) {
return "jwt".equalsIgnoreCase(MetastoreConf.getVar(conf, var));
}
````
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ServletSecurity.java:
##########
@@ -85,21 +85,12 @@ public class ServletSecurity {
private final Configuration conf;
private JWTValidator jwtValidator = null;
- public ServletSecurity(Configuration conf) {
- this(conf, isAuthJwt(conf));
- }
-
public ServletSecurity(Configuration conf, boolean jwt) {
this.conf = conf;
this.isSecurityEnabled = UserGroupInformation.isSecurityEnabled();
this.jwtAuthEnabled = jwt;
}
- public static boolean isAuthJwt(Configuration configuration) {
Review Comment:
can we keep a method just add an extra param?
````
public static boolean isAuthJwt(Configuration conf, MetastoreConf.ConfVars
var) {
return "jwt".equalsIgnoreCase(MetastoreConf.getVar(conf, var));
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
