YuxiangZhuang commented on code in PR #5683:
URL: https://github.com/apache/hive/pull/5683#discussion_r2011184741
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -806,9 +807,9 @@ protected boolean requestIsAborted(final HttpRequest
request) {
// set the specified timeout (socketTimeout jdbc param) for http
connection as well
RequestConfig config = RequestConfig.custom()
- .setConnectTimeout(loginTimeout * 1000)
- .setConnectionRequestTimeout(loginTimeout * 1000)
- .setSocketTimeout(loginTimeout * 1000).build();
+ .setConnectTimeout(connectTimeout)
Review Comment:
this indead introduce a breaking change. we should use msec instead of sec.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
