YuxiangZhuang commented on code in PR #5683:
URL: https://github.com/apache/hive/pull/5683#discussion_r2011200322
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -932,7 +933,7 @@ private TTransport createUnderlyingTransport() throws
TTransportException, SQLEx
String sslTrustStorePassword = Utils.getPassword(sessConfMap,
JdbcConnectionParams.SSL_TRUST_STORE_PASSWORD);
if (sslTrustStore == null || sslTrustStore.isEmpty()) {
- transport = HiveAuthUtils.getSSLSocket(host, port, loginTimeout,
maxMessageSize);
+ transport = HiveAuthUtils.getSSLSocket(host, port, socketTimeout,
connectTimeout, maxMessageSize);
Review Comment:
@deniskuzZ currently the `socketTimeout` and `connectTimeout` use a seconds
unit, `Socket.java` and `TSocket.java` use a milliseconds timeout, so should we
convert the timeout parameters to milliseconds here and other place in
`HiveConnection.java`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
