InvisibleProgrammer commented on code in PR #5709:
URL: https://github.com/apache/hive/pull/5709#discussion_r2017488875
##########
ql/src/java/org/apache/hadoop/hive/ql/plan/PlanUtils.java:
##########
@@ -1230,7 +1229,12 @@ public static Class<? extends AbstractSerDe>
getDefaultSerDe() {
return LazySimpleSerDe.class;
}
- private static final String[] FILTER_OUT_FROM_EXPLAIN = {TABLE_IS_CTAS};
+ private static final String[] FILTER_OUT_FROM_EXPLAIN = {
+ TABLE_IS_CTAS,
+ HIVE_SQL_JDBC_USERNAME,
+ HIVE_SQL_JDBC_PASSWORD,
Review Comment:
Hi,
This ticket came up because of an interesting behavior of explain extended
in case of sys tables:
System tables are special kind of JdbcStorageHandler tables: they are
created with JdbcStorageHandler but they are not containing a jdbc connection
info. Instead of that, they are using the existing connection info provided in
HMS configuration.
The interesting thing is that explain extended is a query. And for queries,
Hive adds the jdbc connection info to the task (I assume because it is required
to be able to run the query).
The questionable behavior is that at sys tables, why we share the JDO
connection info provided in HMS config?
This PR addresses this issue. It is not about show create table or describe
formatted at all. And, for regular JdbcStorageHandler tables, I would expect to
see that information in show create table - as table is created with providing
this info. And this is not the HMS metastore db connection info at all.
So, I'm open to have a discussion or a follow up ticket to rethink what kind
of information we want to share and for what kind of users. But with this PR, I
want to address the case when a simple explain statement can share the HMS
database connection info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
