InvisibleProgrammer commented on code in PR #5709: URL: https://github.com/apache/hive/pull/5709#discussion_r2018724204
########## standalone-metastore/metastore-common/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/hive_metastoreConstants.java: ########## @@ -97,4 +97,10 @@ public static final java.lang.String EXPECTED_PARAMETER_VALUE = "expected_parameter_value"; + public static final java.lang.String HIVE_SQL_JDBC_USERNAME = "hive.sql.dbcp.username"; Review Comment: > Can't we pass hive.sql regex to a filter? It is a great question: if we add a regex pattern to filter this out, there is a chance that we can filter out something in the future that is not implemented yet. And the person who implements it, won't even know about it at all. But on the other hand, there are no huge improvements at Hive - I mean, it looks like a complete software - so I see only a little chance that it will happen. And also, thank you for this comment. I just now realized it is a thrift generated code. So it is definitely a bad idea to put a new constant here - it will be removed as thrift is re-generated. Let me find a proper place to store those constants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
