tanishq-chugh commented on code in PR #5736:
URL: https://github.com/apache/hive/pull/5736#discussion_r2025500443


##########
standalone-metastore/pom.xml:
##########
@@ -173,6 +174,11 @@
         <artifactId>metrics-json</artifactId>
         <version>${dropwizard.version}</version>
       </dependency>
+      <dependency>
+        <groupId>io.netty</groupId>
+        <artifactId>netty-all</artifactId>

Review Comment:
   Have added these deps as well in dependencyManagement in 
[bd96998](https://github.com/apache/hive/pull/5736/commits/bd96998e7b2385e05610bb8b81957ee14bcd0560)
 , so these transitive dependencies are of the same versions.



##########
standalone-metastore/pom.xml:
##########
@@ -92,6 +92,7 @@
     <libthrift.version>0.16.0</libthrift.version>
     <log4j2.version>2.24.3</log4j2.version>
     <mockito-core.version>3.4.4</mockito-core.version>
+    <netty.version>4.1.116.Final</netty.version>

Review Comment:
   Checking it out.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to