Aggarwal-Raghav commented on code in PR #5736:
URL: https://github.com/apache/hive/pull/5736#discussion_r2026518481
##########
pom.xml:
##########
@@ -430,6 +430,16 @@
<artifactId>netty-all</artifactId>
<version>${netty.version}</version>
</dependency>
+ <dependency>
Review Comment:
> We are adding these specifications in dependencyManagement, coz other deps
were bringing in older versions of these transitively and with this addition
we'll get only 4.1.119.Final. We are addressing @Aggarwal-Raghav comment with
this [#5736
(comment)](https://github.com/apache/hive/pull/5736#discussion_r2025071034)
@tanishq-chugh , can you please provide the sonatype report URL for this? I
don't see netty-codec-http coming up in my nexus scan in my org.
Regarding this approach to add dependency of higher version is not a good
idea, IMO, because if higher version of netty is not backward compatible with
older version (required by transitive dependency) then we are prone to
NoSuchMethod or NoClassFound errors at runtime. This is similar to the avro
issue https://github.com/apache/hive/pull/5593 that we last discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
