zratkai commented on code in PR #5676:
URL: https://github.com/apache/hive/pull/5676#discussion_r2029297672
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java:
##########
@@ -219,13 +206,14 @@ protected void doCommit(TableMetadata base, TableMetadata
metadata) {
.filter(key -> !metadata.properties().containsKey(key))
.collect(Collectors.toSet());
}
-
- Map<String, String> summary =
- Optional.ofNullable(metadata.currentSnapshot())
- .map(Snapshot::summary)
- .orElseGet(ImmutableMap::of);
- setHmsTableParameters(
- newMetadataLocation, tbl, metadata, removedProps, hiveEngineEnabled,
summary);
+ HMSTablePropertyHelper.setHmsTableParameters(
+ newMetadataLocation,
+ tbl,
+ metadata,
+ removedProps,
+ hiveEngineEnabled,
+ maxHiveTablePropertySize,
+ currentMetadataLocation());
Review Comment:
For me it failed, and wanted to have it that way. I didn't wanted to have it
that way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
