ngsg commented on code in PR #5674:
URL: https://github.com/apache/hive/pull/5674#discussion_r2024629146
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/columnstats/aggr/LongColumnStatsAggregator.java:
##########
@@ -192,7 +207,13 @@ public ColumnStatisticsObj
aggregate(List<ColStatsObjWithSourceInfo> colStatsWit
csd.setLongStats(aggregateData);
adjustedStatsMap.put(pseudoPartName.toString(), csd);
if (useDensityFunctionForNDVEstimation) {
- densityAvgSum += ((double) (aggregateData.getHighValue() -
aggregateData.getLowValue())) / aggregateData.getNumDVs();
+ if (aggregateData.getNumDVs() == 0) {
Review Comment:
You're right; according to my previous comment, this should be also nonzero.
Thank you for pointing out my mistake. I'll remove is-zero test here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
