ngsg commented on PR #5674: URL: https://github.com/apache/hive/pull/5674#issuecomment-2768472166
@deniskuzZ I've addressed your review and updated the patch accordingly. For the division by zero concerns, I didn't modify the division by `partNames.size()` and `ndvEstimator.estimateNumDistinctValues()` because, if I understand them correctly, they are always positive. Could you please review the changes? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org