difin commented on code in PR #5621: URL: https://github.com/apache/hive/pull/5621#discussion_r2037476635
########## parser/src/java/org/apache/hadoop/hive/ql/parse/AlterClauseParser.g: ########## @@ -116,7 +116,7 @@ optimizeTblRewriteDataSuffix @init { gParent.msgs.push("compaction request"); } @after { gParent.msgs.pop(); } : KW_REWRITE KW_DATA compactPool? whereClause? orderByClause? - -> ^(TOK_ALTERTABLE_COMPACT Identifier["'MAJOR'"] TOK_BLOCKING compactPool? whereClause? orderByClause?) + -> ^(TOK_ALTERTABLE_COMPACT Identifier["'SMART_OPTIMIZE'"] TOK_BLOCKING compactPool? whereClause? orderByClause?) Review Comment: We decided on it during the very first Iceberg compaction PR, because it was convenient for q-tests. It is not required, because now in q-tests we only call EXPLAIN for OPTIMIZE TABLE command, I'll fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org