difin commented on code in PR #5621:
URL: https://github.com/apache/hive/pull/5621#discussion_r2037485059
##########
parser/src/test/org/apache/hadoop/hive/ql/parse/TestParseOptimizeTable.java:
##########
@@ -34,7 +34,7 @@ public void testOptimizeTableWithWhere() throws Exception {
" TOK_TABNAME\n" +
" tbl0\n" +
" TOK_ALTERTABLE_COMPACT\n" +
- " 'MAJOR'\n" +
+ " 'SMART_OPTIMIZE'\n" +
Review Comment:
Because `OPTIMIZE TABLE` syntax doesn't specify compaction type and
previously `MAJOR` was the hardcoded compaction type used by `OPTIMIZE TABLE`.
Now that we have `SMART_OPTIMIZE` I thought it makes more sense to use it to
detect which compaction type is needed instead of always using `MAJOR`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
