kasakrisz commented on code in PR #5757: URL: https://github.com/apache/hive/pull/5757#discussion_r2039016434
########## ql/src/test/queries/clientpositive/cbo_join_transitive_pred_loop_1.q: ########## @@ -1,5 +1,8 @@ set hive.optimize.join.disjunctive.transitive.predicates.pushdown=false; +-- HiveProject(month=[CAST(202503):INTEGER]) +--! qt:replace:/(.*month=\[CAST\()\d+(\).*)/$1#Masked#$2/ Review Comment: IMHO the presence of setting like `hive.test.currenttimestamp` is not safe. Test code should not be shipped with production code. ########## ql/src/test/queries/clientpositive/cbo_join_transitive_pred_loop_1.q: ########## @@ -1,5 +1,8 @@ set hive.optimize.join.disjunctive.transitive.predicates.pushdown=false; +-- HiveProject(month=[CAST(202503):INTEGER]) +--! qt:replace:/(.*month=\[CAST\()\d+(\).*)/$1#Masked#$2/ Review Comment: IMHO the presence of setting like `hive.test.*` is not safe. Test code should not be shipped with production code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
