zabetak commented on code in PR #5757:
URL: https://github.com/apache/hive/pull/5757#discussion_r2039513776
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveUnixTimestampSqlOperator.java:
##########
@@ -29,13 +29,9 @@
*/
public class HiveUnixTimestampSqlOperator {
public static final SqlFunction INSTANCE =
- new SqlFunction("UNIX_TIMESTAMP", SqlKind.OTHER_FUNCTION,
ReturnTypes.BIGINT, null,
+ new HiveSqlFunction("UNIX_TIMESTAMP", SqlKind.OTHER_FUNCTION,
ReturnTypes.BIGINT, null,
OperandTypes.or(OperandTypes.NILADIC,
OperandTypes.or(OperandTypes.STRING, OperandTypes.TIMESTAMP,
OperandTypes.DATE),
- OperandTypes.STRING_STRING), SqlFunctionCategory.NUMERIC) {
- @Override
- public boolean isDynamicFunction() {
- return true;
- }
Review Comment:
I guess we can't do anything else at the moment. If necessary we can revisit
the choice once we upgrade to 1.28+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
