ramitg254 commented on code in PR #5715:
URL: https://github.com/apache/hive/pull/5715#discussion_r2042688951
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -927,6 +931,52 @@ private void
handleAddColumns(org.apache.hadoop.hive.metastore.api.Table hmsTabl
updateSchema.commit();
}
+ private void handleDropColumn(org.apache.hadoop.hive.metastore.api.Table
hmsTable) throws MetaException {
+ List<FieldSchema> hmsCols = hmsTable.getSd().getCols();
+ List<FieldSchema> icebergCols =
HiveSchemaUtil.convert(icebergTable.schema());
+
+ HiveSchemaUtil.SchemaDifference schemaDifference =
HiveSchemaUtil.getSchemaDiff(hmsCols, icebergCols, true);
+
+ if (schemaDifference.getMissingFromFirst().size() > 1) {
+ throw new MetaException("Cannot drop more than one column");
+ }
+
+ if (!schemaDifference.getMissingFromFirst().isEmpty()) {
+ schemaDifference.getMissingFromFirst().forEach(icebergCols::remove);
+ }
+
+ Pair<String, Optional<String>> outOfOrder =
HiveSchemaUtil.getReorderedColumn(
+ hmsCols, icebergCols, ImmutableMap.of());
+
+ if (!schemaDifference.getMissingFromSecond().isEmpty()) {
+ throw new MetaException("Unsupported operation to use DROP COLUMN for
adding a column");
+ }
+
+ if (!schemaDifference.getTypeChanged().isEmpty()) {
+ throw new MetaException("Unsupported operation to use DROP COLUMN for
changing a column type");
+ }
+
+ if (!schemaDifference.getCommentChanged().isEmpty()) {
+ throw new MetaException("Unsupported operation to use DROP COLUMN for
changing a column comment");
+ }
+
+ if (outOfOrder != null) {
Review Comment:
this and other 3 if are handling the below exception which is present in
handleReplaceColumns in an elaborative manner:
```
if (!schemaDifference.getMissingFromSecond().isEmpty() ||
!schemaDifference.getTypeChanged().isEmpty() ||
!schemaDifference.getCommentChanged().isEmpty() || outOfOrder !=
null) {
throw new MetaException("Unsupported operation to use REPLACE COLUMNS
for adding a column, changing a " +
"column type, column comment or reordering columns. Only use
REPLACE COLUMNS for dropping columns. " +
"For the other operations, consider using the ADD COLUMNS or
CHANGE COLUMN commands.");
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
