ramitg254 commented on code in PR #5715:
URL: https://github.com/apache/hive/pull/5715#discussion_r2042678297


##########
common/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java:
##########
@@ -362,6 +363,8 @@ public enum ErrorMsg {
   DBTXNMGR_REQUIRES_CONCURRENCY(10264,
       "To use DbTxnManager you must set hive.support.concurrency=true"),
   TXNMGR_NOT_ACID(10265, "This command is not allowed on an ACID table {0}.{1} 
with a non-ACID transaction manager", true),
+  COLUMN_NOT_FOUND(10266, "Invalid Column Name"),
+  DROP_COLUMN_UNCASCADED(10267, "Drop column is not supported without cascade 
for partitioned table. SerDe may be incompatible.", true),

Review Comment:
   this one is added for more explainatory exception in  case of dropping 
columns without cascade in case of parquet:
   ```
   if (ParquetHiveSerDe.isParquetTable(table) && 
AlterTableUtils.isSchemaEvolutionEnabled(table, context.getConf()) &&
                    !desc.isCascade() && table.isPartitioned()) {
                LOG.warn("Cannot drop column from a partitioned parquet table 
without the CASCADE option");
                throw new HiveException(ErrorMsg.DROP_COLUMN_UNCASCADED, 
desc.getDbTableName());
            }
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to