tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r2046657682
##########
common/src/java/org/apache/hadoop/hive/common/FileUtils.java:
##########
@@ -1007,8 +1007,10 @@ public static boolean rename(FileSystem fs, Path
sourcePath,
// If destPath directory exists, rename call will move the sourcePath
// into destPath without failing. So check it before renaming.
if (fs.exists(destPath)) {
- throw new IOException("Cannot rename the source path. The destination "
- + "path already exists.");
+ throw new IOException("""
+ Cannot rename the source path. The destination \
+ path already exists.\
+ """);
Review Comment:
This has been addressed in
[3b1659a](https://github.com/apache/hive/pull/5404/commits/3b1659a079253eaee786d97b8d4a303c860de11b)
##########
common/src/java/org/apache/hadoop/hive/conf/valcoersion/JavaIOTmpdirVariableCoercion.java:
##########
@@ -50,7 +50,7 @@ private String coerce(String originalValue) {
Path absolutePath = FileUtils.makeAbsolute(LOCAL_FILE_SYSTEM,
originalPath);
return absolutePath.toString();
} catch (IOException exception) {
- LOG.warn(String.format("Unable to resolve 'java.io.tmpdir' for absolute
path '%s'", originalValue));
+ LOG.warn("Unable to resolve 'java.io.tmpdir' for absolute path
'%s'".formatted(originalValue));
Review Comment:
This has been addressed in
[3b1659a](https://github.com/apache/hive/pull/5404/commits/3b1659a079253eaee786d97b8d4a303c860de11b)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
