tanishq-chugh commented on code in PR #5404:
URL: https://github.com/apache/hive/pull/5404#discussion_r2048814234
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DirectSqlInsertPart.java:
##########
@@ -71,7 +72,7 @@ private Long getDataStoreId(Class<?> modelClass) throws
MetaException {
ExecutionContext ec = ((JDOPersistenceManager) pm).getExecutionContext();
AbstractClassMetaData cmd =
ec.getMetaDataManager().getMetaDataForClass(modelClass,
ec.getClassLoaderResolver());
if (cmd.getIdentityType() == IdentityType.DATASTORE) {
- return (Long) ec.getStoreManager().getValueGenerationStrategyValue(ec,
cmd, -1);
+ return (Long) ec.getStoreManager().getValueGenerationStrategyValue(ec,
cmd, null);
Review Comment:
The implementation of getValueGenerationStrategyValue has changed as we have
moved from datanucleus 5.x to 6.x , the behaviour/logic remains similar with
changing from -1 to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
