soumyakanti3578 commented on code in PR #5196:
URL: https://github.com/apache/hive/pull/5196#discussion_r2047383881
##########
ql/src/test/results/clientpositive/llap/excluded_rule_explain.q.out:
##########
Review Comment:
Extra `fields` present in this and other files too.
##########
ql/src/test/results/clientpositive/perf/tpcds30tb/tez/cbo_query13.q.out:
##########
@@ -5,19 +5,19 @@ HiveProject(_o__c0=[/(CAST($0):DOUBLE, $1)],
_o__c1=[CAST(/($2, $3)):DECIMAL(11,
HiveJoin(condition=[=($1, $18)], joinType=[inner], algorithm=[none],
cost=[not available])
HiveJoin(condition=[AND(=($2, $14), OR(AND($15, $7), AND($16, $8),
AND($17, $9)))], joinType=[inner], algorithm=[none], cost=[not available])
HiveJoin(condition=[=($6, $13)], joinType=[inner], algorithm=[none],
cost=[not available])
- HiveProject(ss_cdemo_sk=[$3], ss_hdemo_sk=[$4], ss_addr_sk=[$5],
ss_quantity=[$9], ss_ext_sales_price=[$14], ss_ext_wholesale_cost=[$15],
ss_sold_date_sk=[$22], BETWEEN=[BETWEEN(false, $21, 100:DECIMAL(12, 2),
200:DECIMAL(12, 2))], BETWEEN9=[BETWEEN(false, $21, 150:DECIMAL(12, 2),
300:DECIMAL(12, 2))], BETWEEN10=[BETWEEN(false, $21, 50:DECIMAL(12, 2),
250:DECIMAL(12, 2))], BETWEEN11=[BETWEEN(false, $12, 100:DECIMAL(3, 0),
150:DECIMAL(3, 0))], BETWEEN12=[BETWEEN(false, $12, 50:DECIMAL(2, 0),
100:DECIMAL(3, 0))], BETWEEN13=[BETWEEN(false, $12, 150:DECIMAL(3, 0),
200:DECIMAL(3, 0))])
- HiveFilter(condition=[AND(IS NOT NULL($3), IS NOT NULL($5), IS
NOT NULL($4), IS NOT NULL($6), OR(<=(100:DECIMAL(3, 0), $12), <=($12,
150:DECIMAL(3, 0)), <=(50:DECIMAL(2, 0), $12), <=($12, 100:DECIMAL(3, 0)),
<=(150:DECIMAL(3, 0), $12), <=($12, 200:DECIMAL(3, 0))), OR(<=(100:DECIMAL(12,
2), $21), <=($21, 200:DECIMAL(12, 2)), <=(150:DECIMAL(12, 2), $21), <=($21,
300:DECIMAL(12, 2)), <=(50:DECIMAL(12, 2), $21), <=($21, 250:DECIMAL(12, 2))),
IS NOT NULL($22))])
+ HiveProject(ss_cdemo_sk=[$3], ss_hdemo_sk=[$4], ss_addr_sk=[$5],
ss_quantity=[$9], ss_ext_sales_price=[$14], ss_ext_wholesale_cost=[$15],
ss_sold_date_sk=[$22], EXPR$0=[BETWEEN(false, $21, 100:DECIMAL(12, 2),
200:DECIMAL(12, 2))], EXPR$1=[BETWEEN(false, $21, 150:DECIMAL(12, 2),
300:DECIMAL(12, 2))], EXPR$2=[BETWEEN(false, $21, 50:DECIMAL(12, 2),
250:DECIMAL(12, 2))], EXPR$5=[BETWEEN(false, $12, 100:DECIMAL(3, 0),
150:DECIMAL(3, 0))], EXPR$8=[BETWEEN(false, $12, 50:DECIMAL(3, 0),
100:DECIMAL(3, 0))], EXPR$11=[BETWEEN(false, $12, 150:DECIMAL(3, 0),
200:DECIMAL(3, 0))])
+ HiveFilter(condition=[AND(IS NOT NULL($21), IS NOT NULL($12), IS
NOT NULL($3), IS NOT NULL($5), IS NOT NULL($4), IS NOT NULL($6), IS NOT
NULL($22))])
Review Comment:
I can see that earlier we had similar expressions in both the Filter and the
Project and in now we only have the BETWEENs, which is fine. But I am wondering
if those expressions should be pushed down to the Filter.
##########
ql/src/test/results/clientpositive/llap/external_jdbc_table2.q.out:
##########
@@ -713,16 +713,21 @@ STAGE PLANS:
TableScan
alias: p
properties:
- hive.sql.query SELECT "ikey"
+ hive.sql.query SELECT "ikey", "bkey", "fkey", "dkey"
FROM "EXTERNAL_JDBC_SIMPLE_DERBY2_TABLE1"
-WHERE ("bkey" = 10 AND "dkey" = 15.15 OR "bkey" = 20 AND "dkey" = 25.25) AND
"bkey" IN (10, 20) AND ("dkey" IN (15.15, 25.25) AND "ikey" IS NOT NULL)
Review Comment:
Resolving this as it is no longer relevant.
##########
ql/src/test/results/clientpositive/llap/pcr.q.out:
##########
@@ -1833,7 +1832,7 @@ POSTHOOK: Input: default@pcr_t1@ds=2000-04-10
#### A masked pattern was here ####
OPTIMIZED SQL: SELECT `key`, `value`
FROM `default`.`pcr_t1`
-WHERE `ds` >= '2000-04-08' OR `ds` < '2000-04-10'
+WHERE `ds` IS NOT NULL
ORDER BY `key`, `value`
Review Comment:
This change is explained here:
https://docs.google.com/document/d/167dOnX0LO-zI4Pjt-wfs1ILqjgCq2QJxtRA-RiJcdv0/edit?tab=t.0#heading=h.n5m7m06tr31a
Adding this comment here for other reviewers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
