kasakrisz commented on code in PR #5196:
URL: https://github.com/apache/hive/pull/5196#discussion_r2048811020
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HivePushdownSnapshotFilterRule.java:
##########
@@ -113,7 +112,7 @@ private boolean setSnapShotId(RexNode op1, RexNode op2) {
}
RexLiteral literal = (RexLiteral) op1;
- if (literal.getType().getSqlTypeName().getFamily() !=
SqlTypeFamily.NUMERIC) {
+ if (literal.getTypeName() != SqlTypeName.DECIMAL) {
Review Comment:
How about
```
if (literal.getTypeName() !=
HiveAugmentSnapshotMaterializationRule.snapshotIdType(rexBuilder.getTypeFactory()).getSqlTypeName())
```
The method `snapshotIdType` is used when augmenting the plan with filter
predicates with snapshotId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
