okumin commented on code in PR #5776:
URL: https://github.com/apache/hive/pull/5776#discussion_r2051441325
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
+ FileStatus fileStatus = fs.getFileStatus(file);
+ return new HadoopFileStatus(conf, fs, fileStatus, file);
+ }
+
public FileStatus getFileStatus() {
- return fileStatus;
+ Path symlink;
+ try {
+ symlink= fileStatus.getSymlink();
Review Comment:
```suggestion
symlink = fileStatus.getSymlink();
```
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
Review Comment:
```suggestion
public static HadoopFileStatus createInstance(Configuration conf,
FileSystem fs, Path file) throws IOException {
```
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
+ FileStatus fileStatus = fs.getFileStatus(file);
+ return new HadoopFileStatus(conf, fs, fileStatus, file);
+ }
+
public FileStatus getFileStatus() {
- return fileStatus;
+ Path symlink;
+ try {
+ symlink= fileStatus.getSymlink();
+ }catch (IOException e){
Review Comment:
```suggestion
} catch (IOException e) {
```
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
+ FileStatus fileStatus = fs.getFileStatus(file);
+ return new HadoopFileStatus(conf, fs, fileStatus, file);
+ }
+
public FileStatus getFileStatus() {
- return fileStatus;
+ Path symlink;
+ try {
+ symlink= fileStatus.getSymlink();
+ }catch (IOException e){
+ symlink=null;
Review Comment:
```suggestion
symlink = null;
```
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
+ FileStatus fileStatus = fs.getFileStatus(file);
+ return new HadoopFileStatus(conf, fs, fileStatus, file);
+ }
+
public FileStatus getFileStatus() {
- return fileStatus;
+ Path symlink;
+ try {
+ symlink= fileStatus.getSymlink();
+ }catch (IOException e){
+ symlink=null;
+ }
+ FileStatus other=fileStatus;
Review Comment:
```suggestion
FileStatus other = fileStatus;
```
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
+ FileStatus fileStatus = fs.getFileStatus(file);
+ return new HadoopFileStatus(conf, fs, fileStatus, file);
+ }
+
public FileStatus getFileStatus() {
- return fileStatus;
+ Path symlink;
+ try {
+ symlink= fileStatus.getSymlink();
+ }catch (IOException e){
+ symlink=null;
+ }
+ FileStatus other=fileStatus;
+ return new FileStatus(other.getLen(), other.isDirectory(),
other.getReplication(), other.getBlockSize(), other.getModificationTime(),
other.getAccessTime(), other.getPermission(), other.getOwner(),
other.getGroup(), symlink, other.getPath());
Review Comment:
The length of a single line has to be smaller than or equal to 120 in our
coding style.
##########
shims/common/src/main/java/org/apache/hadoop/hive/io/HdfsUtils.java:
##########
@@ -211,8 +210,20 @@ public HadoopFileStatus(Configuration conf, FileSystem fs,
Path file) throws IOE
this.aclStatus = aclStatus;
}
+ public static HadoopFileStatus createInstance (Configuration conf,
FileSystem fs, Path file) throws IOException {
+ FileStatus fileStatus = fs.getFileStatus(file);
+ return new HadoopFileStatus(conf, fs, fileStatus, file);
+ }
+
public FileStatus getFileStatus() {
- return fileStatus;
+ Path symlink;
Review Comment:
I would like to know the intention of this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
