ramitg254 commented on PR #5776: URL: https://github.com/apache/hive/pull/5776#issuecomment-2816722495
> I'm still reviewing this PR. I found that SonarCloud reported some issues. Could you please resolve ones that this PR should address? https://sonarcloud.io/project/issues?id=apache_hive&pullRequest=5776&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true and regarding the reliability ones the first one is flagging for re-interrupt for an interruption exception which is handled in factory method of that constructor but sonarcloud is not smart enough to understand that and the other one which is for not closing a closable object inside a createInstance factory method which should not be done because that method is used in place of constructor to create object so it does not make sense to close object inside that method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org
