ramitg254 commented on code in PR #5776:
URL: https://github.com/apache/hive/pull/5776#discussion_r2051958832
##########
shims/common/src/main/java/org/apache/hadoop/hive/shims/HadoopShimsSecure.java:
##########
@@ -185,10 +185,27 @@ public float getProgress() throws IOException {
* A generic RecordReader that can hand out different recordReaders
* for each chunk in the CombineFileSplit.
*/
- public CombineFileRecordReader(JobConf job, CombineFileSplit split,
- Reporter reporter,
- Class<RecordReader<K, V>> rrClass)
- throws IOException {
+ public static <K,V> CombineFileRecordReader<K,V> createInstance(JobConf
job, CombineFileSplit split,
+ Reporter
reporter,
+
Class<RecordReader<K, V>> rrClass) throws IOException{
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
