deniskuzZ commented on code in PR #5775:
URL: https://github.com/apache/hive/pull/5775#discussion_r2058022815


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -502,6 +506,9 @@ public void reconnect() throws MetaException {
         // connection has died and the default connection is likely to be the 
first array element.
         promoteRandomMetaStoreURI();
       }
+
+      generateProxyUserDelegationToken();

Review Comment:
   @koodin9, could you please check if only the UGI is missing the token, but 
it's still present in conf?
   ````
   String tokenSig = MetastoreConf.getVar(conf, ConfVars.TOKEN_SIGNATURE);
   tokenStrForm = SecurityUtils.getTokenStrForm(tokenSig);
   if (tokenStrForm != null) {
      SecurityUtils.setTokenStr(UserGroupInformation.getCurrentUser(), 
delegationTokenStr,
               delegationTokenPropString);
      MetastoreConf.setVar(this.conf, ConfVars.TOKEN_SIGNATURE, 
delegationTokenPropString); 
   }
   ````
   PS: I don't think it's reasonable to create a new delegation token on 
reconnect. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to