koodin9 commented on code in PR #5775:
URL: https://github.com/apache/hive/pull/5775#discussion_r2058176831


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -502,6 +510,24 @@ public void reconnect() throws MetaException {
         // connection has died and the default connection is likely to be the 
first array element.
         promoteRandomMetaStoreURI();
       }
+
+      String tokenSig = MetastoreConf.getVar(conf, ConfVars.TOKEN_SIGNATURE);
+      try {
+        tokenStrForm = SecurityUtils.getTokenStrForm(tokenSig);

Review Comment:
   Do you mean I should reset the branch to commit 
[1d9d9c2](https://github.com/apache/hive/pull/5775/commits/1d9d9c2a6a55a950893624e1a6fb5ed93cce8a34)?
   
   As @dengzhhu653 mentioned, if the cost of issuing a new delegation token is 
similar to the cost of checking if the token is valid, then resetting to 
[1d9d9c2](https://github.com/apache/hive/pull/5775/commits/1d9d9c2a6a55a950893624e1a6fb5ed93cce8a34)
 seems like a good idea.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to