bond- opened a new pull request, #5797:
URL: https://github.com/apache/hive/pull/5797

   ### What changes were proposed in this pull request?
   
   This pull request addresses several static analysis issues identified in the 
shell scripts located in the `packaging` folder. The issues were detected using 
ShellCheck and include:
   
   1. **SC2086**: Double quote to prevent globbing and word splitting. Link to 
SC2086
   2. **SC2125**: Brace expansion is not supported in POSIX sh. Link to SC2125
   3. **SC2223**: This default assignment may cause problems when concatenating 
strings. Link to SC2223
   
   ### Why are the changes needed?
   
   These changes are necessary to ensure that the shell scripts in the 
`packaging` folder adhere to best practices and avoid potential issues related 
to globbing, word splitting, brace expansion, and string concatenation. 
Addressing these issues will improve the reliability and maintainability of the 
scripts.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, this PR does not introduce any user-facing changes. It solely focuses on 
improving the internal shell scripts.
   
   ### How was this patch tested?
   
   The patch was tested by running ShellCheck on the modified shell scripts to 
ensure that the identified issues were resolved. Additionally, the scripts were 
manually tested to verify that they function correctly after the changes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org

Reply via email to