asolimando commented on code in PR #5795:
URL: https://github.com/apache/hive/pull/5795#discussion_r2068599205
##########
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/SearchTransformer.java:
##########
@@ -128,8 +132,23 @@ public Shuttle(final RexBuilder rexBuilder) {
} else {
return call;
}
+ case IS_NULL:
+ case IS_NOT_NULL:
+ case CASE:
+ case COALESCE:
+ // Everything below must be transformed with the UNKNOWN handler
Review Comment:
Can you elaborate on why you can't use the outermost handler here?
In the Jira ticket you seem towards the opposite direction, that is taking
into account that in `WHERE` clauses filters obey to the `unknownAsFalse`
semantics.
I haven't reviewed the Calcite upgrade which introduced some of the code you
touch here, so maybe it should be clear from the context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
