deniskuzZ commented on code in PR #5780: URL: https://github.com/apache/hive/pull/5780#discussion_r2079689026
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java: ########## @@ -3254,31 +3247,38 @@ protected List<Partition> getJdoResult(GetHelper<List<Partition>> ctx) throws Me public Partition getPartitionWithAuth(String catName, String dbName, String tblName, List<String> partVals, String user_name, List<String> group_names) throws NoSuchObjectException, MetaException, InvalidObjectException { - boolean success = false; - try { - openTransaction(); - MPartition mpart = getMPartition(catName, dbName, tblName, partVals, null); - if (mpart == null) { - commitTransaction(); - throw new NoSuchObjectException("partition values=" - + partVals.toString()); + return new GetHelper<Partition>(catName, dbName, tblName, false, true) { Review Comment: why refactor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org